[DRAFT] feat(test): Add support for sqllogictests framework #1621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lliangyu-lin
commented
Aug 25, 2025
Comment on lines
+44
to
+45
| spark-connect-rs = { git = "https://github.com/apache/spark-connect-rust.git", rev = "061cb3ecb187b039141f20c722c7984e915f3b9d" } | ||
| #spark-connect-rs = "0.0.2" |
There was a problem hiding this comment.
There seems to have some issues with spark-connect-rs 0.0.2 because it's using arrow 53, and that isn't compatible with chrono 0.4.40+, which is a known problem apache/arrow-rs#7196
New version of spark-connect-rs doesn't seem will be release soon, using git url for right now until new version is released.
There was a problem hiding this comment.
Will this block our release? We don't need to publish this crate, just use it in integration tests.
liurenjie1024
added a commit
that referenced
this pull request
Sep 2, 2025
…1630) ## Which issue does this PR close? - Closes #1214 . ## What changes are included in this PR? * Add schedule definition * Parse schedule to engines involved and test steps * Part of #1621 ## Are these changes tested? Yes, through unit tests. Some parts, like parse engines, require integrations and will be tested once engine and catalog support is added as part of the sql logic tests. --------- Co-authored-by: liurenjie1024 <[email protected]> Co-authored-by: Leon Lin <[email protected]>
| Ok(Self { engines, steps }) | ||
| } | ||
|
|
||
| async fn parse_engines( |
There was a problem hiding this comment.
The parsing logic maintained manually. Would be nice if we could use ser/de framework for them.
There was a problem hiding this comment.
Also applied to creation of engines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?